Deprecate unused Spree::Config#mails_from
#4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Spree::Config#mails_from` setting is not used as the default `From:` field in transactional emails since 2016 [1]. However, the preference still existed albeit being unused. It was also included in the generated `spree.rb`, something that could mislead users. [1] - solidusio@54d12c2
github-actions
bot
added
changelog:solidus_api
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 28, 2023
Please, use Spree::Store#mail_from_address now. Ref solidusio#4712
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 12, 2023
Please, use Spree::Store#mail_from_address now. Ref solidusio#4712
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 14, 2023
Please, use Spree::Store#mail_from_address now. Ref solidusio#4712
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please, use Spree::Store#mail_from_address now. Ref solidusio#4712
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please, use Spree::Store#mail_from_address now. Ref solidusio#4712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spree::Config#mails_fromsetting is not used as the defaultFrom:field in transactional emails since 2016. However, the preference still existed albeit being unused. It was also included in the generatedspree.rb, something that could mislead users.After this one is accepted, we need to update the solidus demo & solidus example apps.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the readme to account for my changes.