Remove Order#fully_discounted? #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is unused anywhere else in Solidus itself, and should be implemented at the store level. Additionally, the current implementation is not correct. For more details, see the related issue: solidusio#481
|
I would add a deprecation warning first and then remove in the next version. This way there's no surprises to anyone using that method in their own apps. |
|
A bit overzealous, I'll admit. Opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is unused anywhere else in Solidus itself, and should be implemented at the store level. Additionally, the current implementation is not correct.
Related discussion: #481