Load stock_items with a deterministic order in OrderInventory#determine_target_shipment
#5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov Report
@@ Coverage Diff @@
## main #5288 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 563 563
Lines 13889 13890 +1
=======================================
+ Hits 12320 12321 +1
Misses 1569 1569
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
force-pushed
the
elia/stock-items-order
branch
2 times, most recently
from
b73b71e
to
f71fb8b
Compare
Ensure stock_items are loaded in a deterministic order inside `determine_target_shipment` and in the spec.
- Explicitly set the count on hand - Add pre-flight expectations - Aggregate failures The flakeyness is very hard to reproduce and if the supposed fixes won't have an effect at least this should give use more information on why it failed.
elia
force-pushed
the
elia/stock-items-order
branch
from
f71fb8b
to
581d2eb
Compare
spaghetticode
approved these changes
Aug 1, 2023
rainerdema
approved these changes
Aug 1, 2023
3 tasks
elia
changed the title
#determine_target_shipmentstock_items with a deterministic order in OrderInventory#determine_target_shipment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure stock_items are loaded in a deterministic order inside
determine_target_shipment.I couldn't recreate the error, but the spec is now more reliable and should give better hints on what went wrong.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: