[Admin] Add text_area component #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptions need to be enclosed in double quotes.
rainerdema
approved these changes
Aug 21, 2023
admin/app/components/solidus_admin/ui/forms/guidance/component.rb
Outdated
Show resolved
Hide resolved
As the logic and styling for the associated label, hint and error messages are the same as for the text_field component, we extract it into a couple of new components: one for the label and one for the guidance (hint and error messages). These new components are marked as private, as they are not meant to be used directly (at least for now). The original text_field component and the new text_area compose the new components but keep the responsibility of how to render the form inputs and which classes or attributes to use. We consider this approach more flexible than, for instance, using inheritance. Although it requires more code than just sharing a bunch of common styles, we keep them decoupled so they can change independently. We stop short of creating another form element component wrapping new extracted pure input and textarea components. We can do that in the future if we need to. Ref. solidusio#5329
waiting-for-dev
force-pushed
the
waiting-for-dev/admin/text_area_component
branch
from
fde9b78
to
65a754d
Compare
waiting-for-dev
merged commit 9d46075
into
solidusio:nebulab/admin
1 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the logic and styling for the associated label, hint and error messages are the same as for the text_field component, we extract it into a couple of new components: one for the label and one for the guidance (hint and error messages). These new components are marked as private, as they are not meant to be used directly (at least for now).
The original text_field component and the new text_area compose the new components but keep the responsibility of how to render the form inputs and which classes or attributes to use. We consider this approach more flexible than, for instance, using inheritance. Although it requires more code than just sharing a bunch of common styles, we keep them decoupled so they can change independently.
We stop short of creating another form element component wrapping new extracted pure input and textarea components. We can do that in the future if we need to.
The first three commits in this PR fix a couple of small issues in the text_field component.
Ref. #5329
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: