-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Add select component #5363
Merged
waiting-for-dev
merged 1 commit into
solidusio:nebulab/admin
from
nebulab:waiting-for-dev/admin/select_box_component
Aug 31, 2023
Merged
[Admin] Add select component #5363
waiting-for-dev
merged 1 commit into
solidusio:nebulab/admin
from
nebulab:waiting-for-dev/admin/select_box_component
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with the other form components, it's design to be used along a Rails' form builder instance. We need to use Javascript to style the select box differently when the prompt option is the one selected. Ref. solidusio#5329
67f81ec
to
86a540d
Compare
the-krg
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Awesome! This will help me a lot on the roles page.
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Sep 1, 2023
solidusio#5363 was merged just before solidusio#5360, so it didn't pick up the rename.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As with the other form components, it's design to be used along a Rails' form builder instance.
We need to use Javascript to style the select box differently when the prompt option is the one selected.
Ref. #5329
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: