Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the page action for creating a new shipping method #5719

Conversation

forkata
Copy link
Contributor

@forkata forkata commented Apr 11, 2024

Summary

It would be helpful to be able to add shipping methods in the new admin, even though the new action views are not migrated yet. This change renames the actions method to page_actions to get that.

Screenshot
Screenshot 2024-04-11 at 3 34 12β€―PM

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • πŸ“– I have updated the README to account for my changes.
  • πŸ“‘ I have documented new code with YARD.
  • πŸ›£οΈ I have opened a PR to update the guides.
  • βœ… I have added automated tests to cover my changes.
  • πŸ“Έ I have attached screenshots to demo visual changes.

It would be helpful to be able to add shipping methods in the new admin,
even though the new views are not migrated yet. This change renames the
actions method to page_actions to get that.

Co-authored-by: Harmony Bouvier <harmony@super.gd>
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ thanks Chris!

@tvdeyen
Copy link
Member

tvdeyen commented Apr 12, 2024

CI Failure fixed in #5721

@tvdeyen tvdeyen merged commit 8a5b257 into solidusio:main Apr 12, 2024
11 of 12 checks passed
@harmonymjb harmonymjb deleted the feature/solidus_admin/add-new-shipping-method-page-action branch April 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants