Fix failing spec for admin logout #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/fix-logout-test-post-navbar-update
branch
from
32d8ae2
to
d94cc58
Compare
elia
approved these changes
Oct 4, 2023
Update the admin logout feature spec to accommodate the UI changes in the admin navigation bar. The 'Logout' link is now nested within a 'details' tag and must be clicked/expanded to access the logout functionality.
``` config/initializers/warden.rb:7:99: C: [Correctable] Rails/FindEach: Use find_each instead of each. ```
rainerdema
force-pushed
the
rainerd/fix-logout-test-post-navbar-update
branch
from
d94cc58
to
3534fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After updating the Solidus navigation bar, the feature spec for admin logout started failing.
The
Logoutlink is now contained within a<details>tag, which needs to be clicked to reveal the logout option.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: