Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing spec for admin logout #249

Merged
merged 2 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/initializers/warden.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Warden::Manager.after_set_user except: :fetch do |user, auth, _opts|
if auth.cookies.signed[:guest_token].present?
if user.is_a?(Spree::User)
Spree::Order.incomplete.where(guest_token: auth.cookies.signed[:guest_token], user_id: nil).each do |order|
Spree::Order.incomplete.where(guest_token: auth.cookies.signed[:guest_token], user_id: nil).find_each do |order|
order.associate_user!(user)
end
end
Expand Down
21 changes: 20 additions & 1 deletion spec/features/admin/sign_out_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,28 @@
end

scenario 'allows a signed in user to logout' do
click_link 'Logout'
click_logout_link
visit spree.admin_login_path
expect(page).to have_text 'Login'
expect(page).not_to have_text 'Logout'
end

def click_logout_link
new_version? ? logout_new_version : logout_old_version
end

def new_version?
Gem::Requirement.new('>= 4.2').satisfied_by?(Spree.solidus_gem_version)
end

def logout_new_version
find('details div', text: user.email, wait: 10).click
within('details') do
click_link 'Logout'
end
end

def logout_old_version
click_link 'Logout'
end
end