Make dependency on Rails > 6.1 explicit #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
approved these changes
Aug 30, 2021
waiting-for-dev
added a commit
to solidusio/solidus-demo
that referenced
this pull request
Aug 30, 2021
Besides keeping the stack up to date, this is needed for the graphql extension to work without errors. See solidusio/solidus_graphql_api#177
|
@waiting-for-dev Hey Marc, can you take a look at linting here? |
There's at least one part of the extension that is not compatible with Rails < 6.1. The `ActiveModel::Errors` handling maps the error collection assuming that what is yielded is an instance of `ActiveModel::Error` (call to `error.attribute`): https://github.com/solidusio-contrib/solidus_graphql_api/blob/9629e8d6b5ee5767265c3e1068a13b2677430a98/lib/solidus_graphql_api/mutations/base_mutation.rb#L36-L41 However, the [`ActiveModel::Error` object is only available from Rails 6.1](https://guides.rubyonrails.org/6_1_release_notes.html#active-model-notable-changes), and before that [it was yielded the error key and message](https://api.rubyonrails.org/v6.0.0/classes/ActiveModel/Errors.html#method-i-each). We also bump the minimal requirement for Solidus to 2.10, as it's the first version that [supported Rails 6.1](https://rubygems.org/gems/solidus_core/versions/2.10.0) (last [2.9 version didn't support it](https://rubygems.org/gems/solidus_core/versions/2.9.6)).
waiting-for-dev
force-pushed
the
waiting-for-dev/explicit_rails_6_1_dependency
branch
from
57ce67e
to
48724a3
Compare
Done! |
kennyadsl
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's at least one part of the extension that is not compatible with
Rails < 6.1. The
ActiveModel::Errorshandling maps the errorcollection assuming that what is yielded is an instance of
ActiveModel::Error(call toerror.attribute):https://github.com/solidusio-contrib/solidus_graphql_api/blob/9629e8d6b5ee5767265c3e1068a13b2677430a98/lib/solidus_graphql_api/mutations/base_mutation.rb#L36-L41
However, the
ActiveModel::Errorobject is only available from Rails6.1, and before that it was yielded the error key and message.
We also bump the minimal requirement for Solidus to 2.10, as it's the
first version that supported Rails 6.1 (last 2.9
version didn't support it).