Fix remote possibility to return wrong current order #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orders' guest token is always populated thanks to a [`before_create` callback on the application layer](https://github.com/solidusio/solidus/blob/ea200dfcc03ed542ab130317ccab4f365c31af7e/core/app/models/spree/order.rb#L128). However, it can be `NULL` in the database. This commit makes sure that no order is returned in two situations: 1. `X-Spree-Order-Token` is not given, and it exists an order with `NULL` guest token. 2. `X-Spree-Order-Token` is provided as an empty string, and it exists an order with an empty string as a guest token. Being defensive against these two options leaves us on the safe side if business rules around the guest token change at some point in solidus-core. This problem is similar to what is fixed in #182
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_order_impersonation
branch
from
e411188
to
cb73bf1
Compare
kennyadsl
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orders' guest token is always populated thanks to a
before_createcallback on the application
layer.
However, it can be
NULLin the database.This commit makes sure that no order is returned in two situations:
X-Spree-Order-Tokenis not given, and it exists an order withNULLguest token.X-Spree-Order-Tokenis provided as an empty string, and it existsan order with an empty string as a guest token.
Being defensive against these two options leaves us on the safe side if
business rules around the guest token change at some point in
solidus-core.
This problem is similar to what is fixed in #182