Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish #72

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Spanish #72

wants to merge 5 commits into from

Conversation

mutalis
Copy link

@mutalis mutalis commented Sep 6, 2016

Bugfix: It not possible to distinguish between the diferent translations to spanish when chosing the locale inside the Admin settings. So it adds missing this_file_language values for the this_file_language keys. Tests are included.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please rename the es-ES locale file back into es-ES.yml again and change the first key into es-ES

Also please remove the RuboCop commit from this PR and make a separate one for this particular change.

@@ -0,0 +1,1338 @@
es:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has to be es-ES: otherwise this locale is used for es instead.

@@ -8,7 +8,7 @@ Style/Documentation:
Enabled: false

# Neatly aligned code is too swell.
Style/SingleSpaceBeforeFirstArg:
Style/SpaceBeforeFirstArg:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not belong into this PR. Could you please open a separate one?

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 11, 2022
@gsmendoza gsmendoza removed the wontfix label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants