Make checkout routes more resource-oriented #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmendoza
commented
Oct 11, 2022
| @@ -0,0 +1,31 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module CheckoutHelper | |||
There was a problem hiding this comment.
I intend to convert this to a component in a follow-up PR.
kennyadsl
reviewed
Oct 12, 2022
|
|
||
| # non-restful checkout stuff | ||
| patch '/checkout/update/:state', to: 'checkouts#update', as: :update_checkout | ||
| resource :checkout, only: [:edit, :update] |
There was a problem hiding this comment.
Shouldn't be checkouts as we are proposing for carts?
There was a problem hiding this comment.
This is the Rails convention for declaring a singular resource. As a singular resource, the paths that the route generates does not have the id param e.g. /checkout instead of checkouts/:id. However, also by Rails convention, the controller mapped to this route maintains a pluralized name (see templates/app/controllers/checkouts_controller.rb).
There was a problem hiding this comment.
Hehe.. No worries!
gsmendoza
force-pushed
the
gsmendoza/sol-477-make-checkout-routes-more-resource
branch
from
2eb988c
to
bc23b2d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As a SolidusStarterFrontend user
I want the checkout routes to be converted to resource routes
So that they fit better into Rails conventions.
Background
This is part of an epic to refactor the order and checkout-related controller. Please see https://docs.google.com/spreadsheets/d/1mV2d4H4Ak9kEvc2bxKUpAv4hiz7FwTUE2t-SfOF7g8E/edit?usp=sharing for the list of changes.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] New feature (non-breaking change which adds functionality)[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
[ ] My change requires a change to the documentation.[ ] I have updated the documentation accordingly.