Move coupon code routes out of order resources #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal ---- As a SolidusStarterFrontend user, I want the coupon code routes moved out of the order resource routes because the coupon codes controller already depends on the current order. As such, the coupon code routes do not need to maintain an order parameter.
gsmendoza
force-pushed
the
gsmendoza/sol-476-move-coupon-code-routes-out-of-order
branch
from
69cd0dc
to
2d0a3ca
Compare
gsmendoza
changed the base branch from
main
to
gsmendoza/sol-477-make-checkout-routes-more-resource
gsmendoza
deleted the
gsmendoza/sol-476-move-coupon-code-routes-out-of-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
This PR can be reviewed because it is no longer expecting additional changes. However, it is set to draft mode until #272 is merged.
Goal
As a SolidusStarterFrontend user, I want the coupon code routes moved out of the order resource routes so that we can remove the unnecessary order parameter from the coupon code URL helpers. The coupon codes controller already depends on the current order.
Background
This is part of an epic to refactor the order and checkout-related controller. Please see https://docs.google.com/spreadsheets/d/1mV2d4H4Ak9kEvc2bxKUpAv4hiz7FwTUE2t-SfOF7g8E/edit?usp=sharing for the list of changes.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] New feature (non-breaking change which adds functionality)[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
[ ] My change requires a change to the documentation.[ ] I have updated the documentation accordingly.