Remove bundled preprocessor libs and unused deps, update Underscore #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package config was not kept current when related features were removed/updated over time
Align with solidus-client
Test both node 0.12.16 and latest 4.x
|
I setup CircleCI to make review easier, ideally I'd like to run tests in both node 0.12 and 4.x which is possible with their parallelism feature and generous 3 container allotment to open source projects. But our account is in a weird place due to the sparkartgroup GitHub org rename, reached out to support to address that later. |
|
An update on the above: parallelism is in full effect 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some quick dependency housecleaning, including the removal of bundled dependencies that was a bad idea from the beginning. I'd go further but there's really an elephant in the room with express 4.x which we'll probably need to address as part of #140. A lingering ancient dependency is Raven, which is now up to 3.x. But this will require more testing than I have time for today.
Underscore is bumped slightly to align with solidus-client.