Merge pull request #127 from greyblake/126_e_notation_coercion

Fix E notation coercion

lib/virtus/coercion/string.rb

@@ -11,8 +11,12 @@ class String < Object
 
       INTEGER_REGEXP    = /[-+]?(?:0|[1-9]\d*)/.freeze
       EXPONENT_REGEXP   = /(?:[eE][-+]?\d+)/.freeze
-      FRACTIONAL_REGEXP = /(?:\.\d+#{EXPONENT_REGEXP}?)/.freeze
-      NUMERIC_REGEXP    = /\A(#{INTEGER_REGEXP}#{FRACTIONAL_REGEXP}?|#{FRACTIONAL_REGEXP})\z/.freeze
+      FRACTIONAL_REGEXP = /(?:\.\d+)/.freeze
+
+      NUMERIC_REGEXP    = /\A(
+        #{INTEGER_REGEXP}#{FRACTIONAL_REGEXP}?#{EXPONENT_REGEXP}? |
+        #{FRACTIONAL_REGEXP}#{EXPONENT_REGEXP}?
+      )\z/x.freeze
 
       # Coerce give value to a constant
       #

spec/unit/virtus/coercion/string/class_methods/to_float_spec.rb

@@ -27,6 +27,11 @@
     '.1e-1'   => 0.01,
     '.1E+1'   => 1.0,
     '.1E-1'   => 0.01,
+    '1e1'     => 10.0,
+    '1E+1'    => 10.0,
+    '+1e-1'   => 0.1,
+    '-1E1'    => -10.0,
+    '-1e-1'   => -0.1,
   }.each do |value, expected|
     context "with #{value.inspect}" do
       let(:string) { value }
@@ -42,4 +47,11 @@
 
     it { should equal(string) }
   end
+
+  context 'string starts with e' do
+    let(:string) { 'e1' }
+
+    # In further version it will raise exception
+    it { should == 'e1' }
+  end
 end

spec/unit/virtus/coercion/string/class_methods/to_integer_spec.rb

@@ -30,6 +30,11 @@
     '.1e-1'        => 0,
     '.1E+1'        => 1,
     '.1E-1'        => 0,
+    '1e1'          => 10,
+    '1E+1'         => 10,
+    '+1e-1'        => 0,
+    '-1E1'         => -10,
+    '-1e-1'        => 0,
     min_float.to_s => min_float.to_i,
     max_float.to_s => max_float.to_i,
   }.each do |value, expected|
@@ -53,4 +58,11 @@
 
     it { should == 334490140000101135  }
   end
+
+  context 'string starts with e' do
+    let(:string) { 'e1' }
+
+    # In further version it will raise exception
+    it { should == 'e1' }
+  end
 end