Fix read defaults after freeze #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2012 20:01
* A fix will be in next commit to allow easy testing.
* As defaults are lazy-set on first access, accessing a attribute with a default on a previously frozen object blows up without this patch. * I choose not to call #get_attributes as this creates an wasted attribute hash.
* This solution should also work for jruby, rbx etc.
| # | ||
| def freeze | ||
| # Call get_attribute on all attribute to ensure defaults are set prior to freezing | ||
| attribute_set.each do |attribute| |
There was a problem hiding this comment.
I would suggest moving this into a private method named something like load_defaults or something clear. You can then move the comment to the method's summary.
|
@mbj this is fantastic, thanks, merged! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.