Fix incompatibilities between rake in devtools and virtus #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit : mbj/devtools@6f2006c We need have rake 10.0 like dependencies. So we have 2 choices. 1) Fix devtools to previous commit 2) Update rake to 10.0 in virtus. This commit do the second choice.
| @@ -19,6 +19,6 @@ Gem::Specification.new do |gem| | |||
| gem.add_dependency('backports', '~> 2.6.1') | |||
| gem.add_dependency('descendants_tracker', '~> 0.0.1') | |||
|
|
|||
| gem.add_development_dependency('rake', '~> 0.9.2') | |||
| gem.add_development_dependency('rake', '~> 10.0') | |||
There was a problem hiding this comment.
@shingara just remove it from gemspec. We'll rely on gemfile from devtools for all develeopment dependencies
There was a problem hiding this comment.
I do another commit delete all development_dependency like you ask
solnic
added a commit
that referenced
this pull request
Dec 19, 2012
…ools Fix incompatibilities between rake in devtools and virtus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit :
mbj/devtools@6f2006c
We need have rake 10.0 like dependencies. So we have 2 choices.
This commit do the second choice.