Fix incompatibilities between rake in devtools and virtus #141

Merged
merged 2 commits into from Dec 19, 2012

Conversation

Projects
None yet
2 participants
@shingara
Contributor

shingara commented Dec 18, 2012

Since commit :
mbj/devtools@6f2006c

We need have rake 10.0 like dependencies. So we have 2 choices.

  1. Fix devtools to previous commit
  2. Update rake to 10.0 in virtus.

This commit do the second choice.

Fix incompatibilities between rake in devtools and virtus
Since commit :
mbj/devtools@6f2006c

We need have rake 10.0 like dependencies. So we have 2 choices.

1) Fix devtools to previous commit
2) Update rake to 10.0 in virtus.

This commit do the second choice.
virtus.gemspec
@@ -19,6 +19,6 @@ Gem::Specification.new do |gem|
gem.add_dependency('backports', '~> 2.6.1')
gem.add_dependency('descendants_tracker', '~> 0.0.1')
- gem.add_development_dependency('rake', '~> 0.9.2')
+ gem.add_development_dependency('rake', '~> 10.0')

This comment has been minimized.

@solnic

solnic Dec 18, 2012

Owner

@shingara just remove it from gemspec. We'll rely on gemfile from devtools for all develeopment dependencies

@solnic

solnic Dec 18, 2012

Owner

@shingara just remove it from gemspec. We'll rely on gemfile from devtools for all develeopment dependencies

This comment has been minimized.

@shingara

shingara Dec 18, 2012

Contributor

I do another commit delete all development_dependency like you ask

@shingara

shingara Dec 18, 2012

Contributor

I do another commit delete all development_dependency like you ask

solnic added a commit that referenced this pull request Dec 19, 2012

Merge pull request #141 from shingara/fix/rake_dependencies_with_devt…
…ools

Fix incompatibilities between rake in devtools and virtus

@solnic solnic merged commit a846b6d into solnic:master Dec 19, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment