Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibilities between rake in devtools and virtus #141

Merged
merged 2 commits into from Dec 19, 2012
Merged

Fix incompatibilities between rake in devtools and virtus #141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af6a133
Fix incompatibilities between rake in devtools and virtus
shingara Dec 18, 2012
aeddff4
delete all development_dependency in gemspec. All is define by devtools
shingara Dec 18, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.devtools
View file
Open in desktop
@@ -1,5 +1,5 @@
group :development do
gem 'rake', '~> 0.9.2'
gem 'rake', '~> 10.0'
gem 'rspec', '~> 2.12.0'
gem 'yard', '~> 0.8.3'
end
Expand Down
2 changes: 1 addition & 1 deletion virtus.gemspec
View file
Open in desktop
Expand Up @@ -19,6 +19,6 @@ Gem::Specification.new do |gem|
gem.add_dependency('backports', '~> 2.6.1')
gem.add_dependency('descendants_tracker', '~> 0.0.1')

gem.add_development_dependency('rake', '~> 0.9.2')
gem.add_development_dependency('rake', '~> 10.0')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shingara just remove it from gemspec. We'll rely on gemfile from devtools for all develeopment dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do another commit delete all development_dependency like you ask

gem.add_development_dependency('rspec', '~> 2.12')
end