bazel\repositories: Update to envoy-fork to pick up callback commit for caching #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EItanya
reviewed
Apr 4, 2022
Comment on lines
+4
to
+5
| commit = "584a730c320c80e44514450f71344549c01722a6", | ||
| remote = "https://github.com/solo-io/envoy-fork", |
There was a problem hiding this comment.
Why are we moving to the fork? This got merged upstream
|
I was bad. I looked at times of 1.21.1 and also checked in for the existence of one of the two upstream PRs that you made. Unfortunately when rebuilding Enterprise envoy-gloo with caching I kept hitting an issue that I was sure wasnt the case until I actually looked correctly. |
|
Master in envoy is considered safe to use iirc, especially in betas, so we can probably use that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have done this instead of the normal upgrade to 1.21
That being said this singular commit didnt make it into upstreams 1.21 release by a couple days so needs to exist here for caching in envoy-gloo-ee