Skip to content

Commit

Permalink
Fix CI (#2011)
Browse files Browse the repository at this point in the history
* Test if this fixes CI
* Make with -B to ensure we don't have tagged version of helm file lying around in CI
* Revert makefile change
* Add changelog
* Move changelog
  • Loading branch information
kdorosh authored and soloio-bulldozer[bot] committed Dec 19, 2019
1 parent 5c34445 commit a1ad17b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog/v1.2.12/fix-ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
changelog:
- type: NON_USER_FACING
description: >
Fix CI after helm values docsgen PR broke build. (PR: https://github.com/solo-io/gloo/pull/1993)
issueLink: https://github.com/solo-io/gloo/issues/1643
2 changes: 1 addition & 1 deletion install/test/helm_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func TestHelm(t *testing.T) {

var _ = BeforeSuite(func() {
// generate the values.yaml and Chart.yaml files
MustMake(".", "-C", "../../", "generate-helm-files")
MustMake(".", "-C", "../../", "generate-helm-files", "-B")
})

type renderTestCase struct {
Expand Down

0 comments on commit a1ad17b

Please sign in to comment.