-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy_latency_response_out is always equal to DURATION time of the request #9317
Comments
Reproducer project: https://github.com/DuncanDoyle/ge-gloo-9317 |
Proxy latency definitely needs more docs. However this is what it does: it gets the total time in the proxy so that it can report what the overhead of using the proxy is. In this case the reproduction steps involve setting a delay via the fault filter https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/fault_filter which can do things like simulate a delay on a request. Unfortunately in this case we have the following issue fault filter is technically in envoy and therefore counts towards proxy latency filters time. EDIT: removing a section previously here about nighthawk. While it had mostly correct info it actually had a piece that was not quite right. Clarifying comment below. |
Reopened for two parts. Issue as stated here: Gap: Possible follow ups:
|
After further investigation it seems like we should mainly push users to recreate these stats if needed in metadata. |
Put up PR for this. Includes some additional documentation around how this plays with commun_duration envoyproxy/envoy#33240 |
Gloo Edge Product
Enterprise
Gloo Edge Version
1.15.x
Kubernetes Version
1.26
Describe the bug
Testing with proxyLatency response_out, I observed that
Is always equal to:
Expected Behavior
For me, latency for response_out should only measure the latency on response time, not having the same value as duration of the total request.
Steps to reproduce the bug
Gateway object:
Inject some fault injection on request:
As you see, I have a delay of 2s on the request, however, if I check my logs:
proxy_latency_response_out is always taking the total response time
Additional Environment Detail
No response
Additional Context
No response
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: