-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access log: added new COMMON_DURATION command #33240
Conversation
Signed-off-by: wbpcode <wbphub@live.com>
I personally think the name of the time point is too long, may be we should use some short names here? Here are current supported time point name:
May be we can use some short abbreviations, for example:
Then, the |
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
This is new feature, so let's use the short name. it will make the log template simpler
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be really helpful when debuging, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good. Some minor comments below.
Signed-off-by: wbpcode <wbphub@live.com>
/retest |
* access log: added new COMMON_DURATION command Signed-off-by: wbpcode <wbphub@live.com> * fix docs Signed-off-by: wbpcode <wbphub@live.com> * use short name Signed-off-by: wbpcode <wbphub@live.com> * fix format Signed-off-by: wbpcode <wbphub@live.com> * user lower case for precisons Signed-off-by: wbpcode <wbphub@live.com> * address comments Signed-off-by: wbpcode <wbphub@live.com> --------- Signed-off-by: wbpcode <wbphub@live.com>
Commit Message: access log: added new COMMON_DURATION command
Additional Description:
Added :ref:%COMMON_DURATION% to access log format to log the duration of the request. The start time point, end time point and duration precision can be configured in this new command.
For example, given following command
%COMMON_DURATION(DS_RX_BEG, US_TX_BEG, us)%
,Envoy will log the duration from the downstream request start to the upstream request start in the microseconds.
To close #33001
Risk Level: low.
Testing: unit.
Docs Changes: added.
Release Notes: added.
Platform Specific Features: n/a.