Rewrite prefix API flatten and auto_host_rewrite fix #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdorosh
changed the title
ilackarms
reviewed
Oct 7, 2019
| @@ -75,4 +75,4 @@ func (resolvers Resolvers) Resolve(us *v1.Upstream) (*url.URL, error) { | |||
|
|
|||
| // flow: | |||
| // upstream type: aws | |||
| // detector type: swagger (can only be used with upstreams that have a url that's resolavable) | |||
| // detector type: swagger (can only be used with upstreams that have a url that's resolvable) | |||
ilackarms
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
auto_host_rewriteinto the host rewrite oneof and removes it from the static upstream specauto_host_rewriteon other upstream types (e.g., aws/azure) without relying on a static upstream to override the entire route configContext
The current implementation of
auto_host_rewritehad a confusing side-effect where a single static upstream on a route would setauto_host_rewritefor the entire route.Envoy
RouteActiondocs for reference: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/route/route.proto#route-routeaction (where all these rewrite actions live)BOT NOTES:
resolves #1322