Regression tests #478
Regression tests #478
Conversation
Makefile
Outdated
| docker build -t soloio/gloo-envoy-wrapper:$(VERSION) $(OUTPUT_DIR) -f $(OUTPUT_DIR)/Dockerfile.envoyinit | ||
| docker build $(OUTPUT_DIR) -f $(OUTPUT_DIR)/Dockerfile.envoyinit \ | ||
| -t soloio/gloo-envoy-wrapper:$(VERSION) \ | ||
| -t $(GCR_REPO_PREFIX)/gloo-envoy-wrapper:$(TEST_IMAGE_TAG) |
There was a problem hiding this comment.
this will create a test tag every time. is this intentional?
will it still work if those variable not provided - like in local dev?
There was a problem hiding this comment.
The fact that it creates a tag every time is intentional, I am basically piggybacking off the original build command instead of running it again as I figured that creating a tag is an inexpensive operation.
Good point regarding the local builds, I will find a sensible way of addressing that.
cloudbuild.yaml
Outdated
| waitFor: ['build-test-assets', 'test'] | ||
|
|
||
| - name: gcr.io/cloud-builders/gcloud | ||
| args: ['container', 'clusters', 'get-credentials', 'kube2e-tests'] |
There was a problem hiding this comment.
why is this needed? we have other tests that use a test cluster already, why do we need to get credentials again?
There was a problem hiding this comment.
We are using a different cluster here (kube2e-test vs test-cluster) so we need to update the KUBECONFIG. I thing the reason for using different clusters was that we want to isolate the two test phases, potentially having them run in parallel (Also, we already had a GKE cluster available that was not being used)
test/helpers/install_helm_chart.go
Outdated
| } | ||
|
|
||
| func WaitPodStatus(ctx context.Context, interval time.Duration, label, status string, finished func(output string) bool) error { | ||
| //func WaitPodsTerminated(ctx context.Context, interval time.Duration, labels ...string) error { |
There was a problem hiding this comment.
Done. Actually removed the whole file, since it was not used.
cloudbuild.yaml
Outdated
| waitFor: ['compile'] | ||
| id: 'build-test-assets' | ||
|
|
||
| - name: gcr.io/cloud-builders/gcloud |
There was a problem hiding this comment.
This one as well. The e2e-ginkgo container authenticates by default
There was a problem hiding this comment.
Oh, didn't realize it. Thanks, I'll removed those two steps then.
test/helpers/install_helm_chart.go
Outdated
| @@ -51,7 +51,7 @@ func DeployGlooWithHelm(namespace, imageVersion string, enableKnative, verbose b | |||
| return nil | |||
| } | |||
|
|
|||
| func GlooHelmValues(namespace, version string, enableKnative bool) io.Reader { | |||
| func glooHelmValues(namespace, version string, enableKnative bool) io.Reader { | |||
| b := &bytes.Buffer{} | |||
|
|
|||
| err := template.Must(template.New("gloo-helm-values").Parse(` | |||
There was a problem hiding this comment.
I realize this isn't technically part of this PR, but it seems like these values should be pulled from the actual file rather than trying to keep this in line with the real file
There was a problem hiding this comment.
Actually, thanks for reminding me, most of this code is not used anymore, so I can just remove it and move the only used function (WaitPodsRunning) to the testrunner file.
| @@ -204,6 +213,6 @@ func ToFile(content string) string { | |||
| n, err := f.WriteString(content) | |||
| ExpectWithOffset(1, err).NotTo(HaveOccurred()) | |||
| ExpectWithOffset(1, n).To(Equal(len(content))) | |||
| f.Close() | |||
| _ = f.Close() | |||
There was a problem hiding this comment.
The IDE laments about an unhandled error. The _ = makes it explicit that we chose not to handle it.
|
actually one more comment - add the larger machine type in cloud build yaml? |
It will soon push a commit with all the requested changes, including the larger machine type. |
# Conflicts: # changelog/v0.8.5/1.yaml
changelog/v0.8.6/1.yaml
Outdated
| @@ -0,0 +1,3 @@ | |||
| changelog: | |||
There was a problem hiding this comment.
It doesn't matter for this change, but I would start naming these yaml files something unique to the PR to avoid the possibility of merge conflicts with other open PRs.
|
/kick |
The new tests in the
test/kube2epackage install the 3 versions of gloo (gateway,ingress, andknative) and run smoke tests against them to identify regressions. The tests rely on assets in the_testdirectory which are build in previous build steps.See the comments in the
Makefileand theREADMEin the test directory for more info.