Do settings as a pre-install hook #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2019 10:14
|
Issues linked to changelog: |
rickducott
added
the
work in progress
|
/kick |
|
Only change since @marcogschmidt reviewed was rearranging some tests (removed tests that were broken and never run, added tests that are relatively fast to start testing install command). Not happy with coverage for the new functions but it is hard to test, regression tests should provide sufficient assurance that install still works however. |
rickducott
removed
the
work in progress
marcogschmidt
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids race condition where settings gets created by the pod first, causing the install to fail. Also includes a small refactor to minimize code dupe.