-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy protocol support to gateway deployments #676
Add proxy protocol support to gateway deployments #676
Conversation
Waiting for approval from someone in the solo-io org to start testing. |
Issues linked to changelog: |
/test |
hi @techmunk, i can't understate how impressed I am by this PR! You seem to have very quickly grokked many things about Gloo. really quite impressive! this lgtm and is a nice feature to add. in order to get any PR that modifies the steps for doing so are:
from the root of the gloo project directory. we really ought to document these steps for contributors.. sorry it's not already done! |
@ilackarms Thanks for the feedback! grep and google are my friends.
All of it seems like formatting and style guide stuff. Is there something else I'm missing or not got setup correctly? Or is the above expected? |
I've pushed it all up. I'm not convinced it should all be added though. |
Ok. Figured it out. I was running with protoc v 3.7.0. Downgraded to 3.6.1 and this seems a bit more like what I was expecting. |
sorry, should have mentioned our builds use 3.6.1. still impressed. |
/test |
I've been seeing this on other projects too -- we should probably add a solo-kit check that ensures the exact version of protoc is on the path or print a helpful error message. solo-io/solo-kit#135 Alternatively we could add it to the solo kit wrapper in this repo. |
As per the subject, this adds support for the envoy proxy protocol flag for gateway deployments. This is my first time coding in Go and I'd never heard of Gloo 12 hours ago so please be gentle. :)
I was unsure if I needed to commit the generated code stuff or not as it seemed to change a lot more than just the stuff I had modified. Hopefully this is a CI thing.
I've tested this code with a haproxy instance using the following listener config and it seems to work:
I updated the default gateways using the following command
Everything seems to be working just fine.
BOT NOTES:
resolves #676