Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose isolateVirtualHostsBySslConfig as a values yaml parameter… #7090

Closed
wants to merge 2 commits into from

Conversation

avizov
Copy link

@avizov avizov commented Sep 5, 2022

Description

Expose isolateVirtualHostsBySslConfig as a values yaml parameter to enable setting it in the settings.yaml

Context

this PR allows consuming the fix from this issue #6677

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-build-bot
Copy link

solo-build-bot bot commented Sep 5, 2022

Waiting for approval from someone in the solo-io org to start testing.

@solo-changelog-bot
Copy link

Issues linked to changelog:
#6476

@avizov avizov marked this pull request as draft September 5, 2022 11:31
@solo-changelog-bot
Copy link

Issues linked to changelog:
#6677

@avizov avizov marked this pull request as ready for review September 5, 2022 11:49
@gunnar-solo
Copy link
Contributor

/run-ci

@gunnar-solo
Copy link
Contributor

replaced with #7095

@gunnar-solo gunnar-solo closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants