-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCM overrides do not support 0-value overrides #6476
Comments
this is a real ...ish issue. It's mostly a logic problem. Consider the field
because booleans cannot be nil, our current implementation gives us these possibilities:
it is totally possible to logically write code to override true to false, exactly as we want. The problem comes when we consider all unset user fields will always be false in such a case. consider such a case, where a child value of unset could override a parent's true:
|
mergo (the merging library we're currently using) calls this concept "overwriting with a 0 value" to be more data structure agnostic (consider enums, empty strings, the number 0...). Similar user issue. By specifying |
Three possible approaches to resolve this issue:
|
Related to #6532 |
We have come across another scenario where this issue rises. |
Hi, Seems that the type of Thanks for your reference. |
Gloo Edge Version
1.11.x (latest stable)
Kubernetes Version
1.22.x
Describe the bug
This feature #6414 presented an option to override settings with delegated gateways.
As described in the feature:
preventChildOverrides=false | {"parent":{"foo":"bar"}, "child":{"foo":"baz"}} --> {"foo":"baz"}
When setting a parent gateway with a boolean prop true and a child gateway with the same boolean prop false, the override is not working.
For example:
Parent gateway:
Child gateway:
The observed behavior was that http1.0 yet was accepted
The text was updated successfully, but these errors were encountered: