Add UUID to api keys #7972
Merged
Add UUID to api keys #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
|
Visit the preview URL for this PR (updated for commit 01add25): https://gloo-edge--pr7972-rinormaloku-add-uuid-ltxyzvcc.web.app (expires Thu, 23 Mar 2023 08:43:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
rinormaloku
removed
the
keep pr updated
|
Issues linked to changelog: |
jbohanon
reviewed
Mar 16, 2023
rinormaloku
commented
Mar 16, 2023
| @@ -977,6 +977,8 @@ message ApiKey { | |||
| repeated string labels = 3; | |||
| // additional data the client needs associated with this API key | |||
| map<string, string> metadata = 4; | |||
| // Optional: Unique identifier for the API key | |||
There was a problem hiding this comment.
@ashleywang1 can we use here an annotation to hide this from the public docs as this is an implementation detail for storing this info in the storage?
There was a problem hiding this comment.
@jbohanon asked in gloo-platform-core and this doesn't seem to be supported
jbohanon
approved these changes
Mar 16, 2023
jmhbh
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to implement the following GH issue: https://github.com/solo-io/gloo-mesh-enterprise/issues/7756
Which has the option for API Keys to be hashed and in order to query API keys we need the UUID