Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UUID to api keys #7972

Merged
merged 3 commits into from Mar 16, 2023
Merged

Add UUID to api keys #7972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e34f99
Add UUID to api keys
rinormaloku Mar 15, 2023
235b185
executed codegen
rinormaloku Mar 15, 2023
01add25
added changelog
rinormaloku Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/v1.14.0-beta16/add-uuid-to-apikeys.yaml
View file
Open in desktop
@@ -0,0 +1,5 @@
changelog:
- type: NON_USER_FACING
issueLink: https://github.com/solo-io/gloo-mesh-enterprise/issues/7756
resolvesIssue: false
description: Add uuid property to Api Keys, used as an identifier for Hashed Api Keys
2 changes: 2 additions & 0 deletions ...-io/gloo/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto.sk.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto
View file
Open in desktop
Expand Up @@ -977,6 +977,8 @@ message ApiKey {
repeated string labels = 3;
// additional data the client needs associated with this API key
map<string, string> metadata = 4;
// Optional: Unique identifier for the API key
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleywang1 can we use here an annotation to hide this from the public docs as this is an implementation detail for storing this info in the storage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbohanon asked in gloo-platform-core and this doesn't seem to be supported

string uuid = 5;
jbohanon marked this conversation as resolved.
Show resolved Hide resolved
}

// DEPRECATED: use ApiKey
Expand Down
2 changes: 2 additions & 0 deletions projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.clone.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.equal.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,390 changes: 700 additions & 690 deletions projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.hash.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.