Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build and load sds standard image for tests #9367

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Apr 15, 2024

Description

The glooctl istio inject command always injects the standard sds image variant irrespective of the variant of edge installed. As tests run on the distroless variant, this PR ensures the standard sds image is built and loaded so the glooctl test passes while we fix the underlying issue

Context

https://github.com/solo-io/gloo/actions/runs/8683582052/job/23826553002?pr=9358
https://solo-io-corp.slack.com/archives/G01EERAK3KJ/p1713193713670019

 Back-off pulling image "quay.io/solo-io/sds:1.0.0-ci1"
  Warning  Failed     30s (x3 over 56s)  kubelet            Error: ImagePullBackOff
  Warning  Failed     15s (x3 over 59s)  kubelet            Error: ErrImagePull
  Warning  Failed     15s (x3 over 59s)  kubelet            Failed to pull image "quay.io/solo-io/sds:1.0.0-ci1": rpc error: code = NotFound desc = failed to pull and unpack image "quay.io/solo-io/sds:1.0.0-ci1": failed to resolve reference "quay.io/solo-io/sds:1.0.0-ci1": quay.io/solo-io/sds:1.0.0-ci1: not found

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Apr 15, 2024
Copy link

github-actions bot commented Apr 15, 2024

Visit the preview URL for this PR (updated for commit 840204c):

https://gloo-edge--pr9367-fix-glooctl-istio-in-d76qvbfm.web.app

(expires Tue, 23 Apr 2024 17:08:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@davidjumani davidjumani changed the title [WIP] always build and load sds standard Always build and load sds standard image used by tests Apr 16, 2024
@davidjumani davidjumani changed the title Always build and load sds standard image used by tests Always build and load sds standard image for tests Apr 16, 2024
@davidjumani
Copy link
Contributor Author

Followup issue #9372

Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely hacky as we expect our tools like istio injection to be deciding on the right sds container type (fips, distorless, default). However given that we do not support this today I am ok with us building this non-distroless image to unblock our tests

@soloio-bulldozer soloio-bulldozer bot merged commit 6471ad7 into main Apr 16, 2024
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the fix-glooctl-istio-inject branch April 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants