Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Added console basic routing guide #111

Merged
merged 7 commits into from Mar 6, 2019
Merged

Conversation

scranton
Copy link
Contributor

@scranton scranton commented Mar 6, 2019

No description provided.

@rickducott
Copy link
Contributor

The initial console upstreams are fixed in 0.10.7, let's take a new screen shot

Copy link
Contributor

@rickducott rickducott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about the voice in 2 places. The pictures get pretty large but that's not unique to this guide, and I'm happy to address it in a future PR

apiserver-ui NodePort 10.97.69.208 <none> 8088:31242/TCP 129m
```

So to open the Gloo Enterprise Console, in this example, I'd open a browser to `192.168.99.102:31242`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few spots in here where the first person voice feels a bit much -- "I'd open a browser", "my cluster IP". I would change these to something like:

"So to open the Gloo Enterprise Console, navigate to ... in the browser. "

"In this example, the Cluster IP is ..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think technical docs are usually in 3rd person / passive voice, but I don't really mind the rest (not worth changing all the "you"s, etc) especially as a user guide

@scranton scranton merged commit 8fbff29 into solo-io:master Mar 6, 2019
@scranton scranton deleted the console-docs branch March 6, 2019 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants