-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands for credential management #68
Comments
Great idea! I'd suggest some changes:
|
and as noted on other places I am not really a fan of passing the pin directly as an argument. but generally speaking i would TOTALLY dig this, especially as the tool built into chrome (unless you are using windows 10 1903 or higher, where it is hidden due to w10 intercepting fido calls) doesnt seem to work for some reason |
I'd suggest bunching everything under How PIN entry is handled is orthogonal, the important thing is that it's consistent with other functionality. Ideally I think it should use either an env like |
an env doesnt really make this awesome as it makes it harder to use for people who aren't THAT well versed with computers, and would you enter your password as a parameter to sudo or passwd? I doubt it. but yeah having all under a seperate credential "submenu" makes sense. although I would keep the old solo key make-credential as an alias for at least a while for compatibility and stuff. also talking about make credential, it might be nice to have an option to choose whether to create resident or "normal" credentials. |
Please open a separate issue for your recurring comments on how to pass PIN :) |
okay done -> #70 |
I combined the feedback from @nickray and @conorpp and came up with this:
Solo credential IDs are very long, so I choose to show them in base64 instead of hex string. Let me know what you think. |
I have seen credential IDs (and U2F Keyhandles) mostly in base64 or base64url, so that's actually ideal. but this looks fun, maybe add the create credential command too so all is in one nice place, but interesting that the relying party can be even something that isnt a hostname/domain ("ssh:") especially as the CTAP2 document links the "relying party identifier" directly over to webauthn, which calls it a "valid domain string" https://fidoalliance.org/specs/fido2/fido-client-to-authenticator-protocol-v2.1-rd-20191217.html although I think having a bit of uniformity across the commands might be helpful, like why is listing solos |
Good point. We should either: I think I prefer a) but it's up to the Solo guys to decide |
but if b keep a documented (but not listed in help) alias to maintain compatibility |
It's fine to have synonyms, but we should keep the existing commands as they're in docs, and changing would be a breakimg semver change. Maybe if you really want Some tools even let you use just as many characters to disambiguate, (e.g. One comment on arguments vs. options, it seems to me that |
I like using |
I like a lot that Also for optional arguments, so far we've used Alright, enough bikeshedding XD. I should write down documentation of the philosophy in the repo to share knowledge... |
I have updated the PR with the following changes:
|
Since we are adding credential management support in Solo, I believe we also need relevant commands in solo-python. I propose the following CLI interface:
I can easily implement this one if others are OK with that.
The text was updated successfully, but these errors were encountered: