Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プレイヤー操作周り修正 #31

Merged
merged 8 commits into from
Jan 3, 2014
Merged

プレイヤー操作周り修正 #31

merged 8 commits into from
Jan 3, 2014

Conversation

lettas
Copy link
Contributor

@lettas lettas commented Jan 3, 2014

設計の思想に気持ちの迷いを感じるが、修正してみました。

方針

  • InputHandlerは入力のバッファに専念する(getDirectionのくだりは専念し切れてない)
  • entityのupdate内で入力を取り出してほげほげする

毎回呼び出しててつらポヨなところは極力memoizeしてみたけど、どうでしょうか。

@karihei
Copy link
Contributor

karihei commented Jan 3, 2014

おおー、引っ掛かりが無くなった!

// ビーム
var mouseDown = this.inputHandler.shiftMouseDownEvent();
if (mouseDown) {
console.log(mouseDown);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ消しとく?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ごめんくさい

karihei added a commit that referenced this pull request Jan 3, 2014
@karihei karihei merged commit b9d460e into master Jan 3, 2014
@karihei karihei deleted the feature/player_move branch January 3, 2014 16:01
@karihei
Copy link
Contributor

karihei commented Jan 3, 2014

待ち焦がれたやつなのでソッコーマージするし

@lettas
Copy link
Contributor Author

lettas commented Jan 3, 2014

みさわ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants