Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リソース周りを整理 #84

Merged
merged 4 commits into from
Feb 14, 2014
Merged

リソース周りを整理 #84

merged 4 commits into from
Feb 14, 2014

Conversation

karihei
Copy link
Contributor

@karihei karihei commented Feb 12, 2014

マージ シテ。

  • resource.jsの名前整理
  • player関係のアニメーションはこれから増えそうなのでimg以下に専用のディレクトリ掘った
  • 同じ理由でビームのディレクトリ掘った
  • 使ってない画像削除

ほんとは死亡モーションを実装しようとしたけどとりあえず先にリファクタ。
死亡モーションは別プルリクにします。

var s_ImgPlayerWalking = 'res/img/player/walk.png';
var s_ImgBeam0 = 'res/img/beam/star.png';
var s_ImgSimpleBeam = 'res/img/beam/simple.png';
var s_ImgSmoke0 = 'res/img/beam/smoke.png';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

画像は s_Img を接頭辞にする

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

というコメントがあるとうれしいっす

@nise-nabe
Copy link
Contributor

さようなら謹賀新年

@lettas
Copy link
Contributor

lettas commented Feb 14, 2014

karihei++

@karihei
Copy link
Contributor Author

karihei commented Feb 14, 2014

いろいろ対応した

iwag added a commit that referenced this pull request Feb 14, 2014
リソース周りを整理といろいろリファクタ
@iwag iwag merged commit 0c75a30 into master Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants