Revert fa21d6e18904df4c6c05f3d93c7f911e90f7b6f4 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was wrong in the review solvcon#167 (review) to think it is ok to set vertex size to an illegal value. It is not because it may result into memory error. I think it is implied in the qt3d doc: https://doc.qt.io/qt-6/qt3dcore-qattribute.html#vertexSize-prop. I will file an issue to track it. The vertex size may be an important parameter for qt3d and I do not fully understand its meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wrong in the review #167 (review) to think it is ok to set vertex size to an illegal value. It is not because it may result into memory error. I think it is implied in the qt3d doc: https://doc.qt.io/qt-6/qt3dcore-qattribute.html#vertexSize-prop.
I will file an issue to track it. The vertex size may be an important parameter for qt3d and I do not fully understand its meaning.
On my macos, using 5 causes wrong rendering of the lines.