Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert fa21d6e18904df4c6c05f3d93c7f911e90f7b6f4 #170

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Revert fa21d6e18904df4c6c05f3d93c7f911e90f7b6f4 #170

merged 1 commit into from
Dec 10, 2022

Commits on Dec 10, 2022

  1. Revert fa21d6e 

    I was wrong in the review solvcon#167 (review) to think it is ok to set vertex size to an illegal value.  It is not because it may result into memory error.  I think it is implied in the qt3d doc: https://doc.qt.io/qt-6/qt3dcore-qattribute.html#vertexSize-prop.

I will file an issue to track it.  The vertex size may be an important parameter for qt3d and I do not fully understand its meaning.
    @yungyuc
    yungyuc committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    3b2d907 View commit details
    Browse the repository at this point in the history