Check return values of fread, etc in ReadFile/WriteFile.

solvespace · Jan 10, 2019 · 8e4c4b0 · 8e4c4b0
1 parent 8f2af5b
commit 8e4c4b0
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/platform/platform.cpp b/src/platform/platform.cpp
@@ -419,11 +419,15 @@ bool ReadFile(const Platform::Path &filename, std::string *data) {
     FILE *f = OpenFile(filename, "rb");
     if(f == NULL) return false;
 
-    fseek(f, 0, SEEK_END);
+    if(fseek(f, 0, SEEK_END) != 0)
+        return false;
     data->resize(ftell(f));
-    fseek(f, 0, SEEK_SET);
-    fread(&(*data)[0], 1, data->size(), f);
-    fclose(f);
+    if(fseek(f, 0, SEEK_SET) != 0)
+        return false;
+    if(fread(&(*data)[0], 1, data->size(), f) != data->size())
+        return false;
+    if(fclose(f) != 0)
+        return false;
 
     return true;
 }
@@ -432,8 +436,10 @@ bool WriteFile(const Platform::Path &filename, const std::string &data) {
     FILE *f = OpenFile(filename, "wb");
     if(f == NULL) return false;
 
-    fwrite(&data[0], 1, data.size(), f);
-    fclose(f);
+    if(fwrite(&data[0], 1, data.size(), f) != data.size())
+        return false;
+    if(fclose(f) != 0)
+        return false;
 
     return true;
 }