Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font texture update not working #151

Closed
Evil-Spirit opened this issue Jan 9, 2017 · 9 comments
Closed

Font texture update not working #151

Evil-Spirit opened this issue Jan 9, 2017 · 9 comments
Labels
Milestone

Comments

@Evil-Spirit
Copy link
Collaborator

System information

Windows, OpenGL2

Expected behavior

Font texture should be updated for each OpenGL context.

Actual behavior

Font texture updated only for context where new character appears

Additional information

For native windows OpenGL there are possible to use the same context for different windows, or share context resources by using wglShareLists. Unfortunately, this approach can't work with ANGLE, so we have to support two contexts and update font texture for each of them.

@whitequark
Copy link
Contributor

yes, I also noticed this bug, please fix it

@Evil-Spirit
Copy link
Collaborator Author

@whitequark,
I have no idea how to make this not using some hacking.

  1. The best solution I know is perfrom versioning of the font texture and store it inside pixmapCache.
  2. Make copy of the font for each Canvas instance

@whitequark
Copy link
Contributor

@Evil-Spirit 2nd sounds OK to me

@Evil-Spirit
Copy link
Collaborator Author

@whitequark, OK!? ok :)

Evil-Spirit added a commit to Evil-Spirit/solvespace-master that referenced this issue Jan 10, 2017
@Evil-Spirit
Copy link
Collaborator Author

@whitequark, ready

@whitequark whitequark added the bug label Jan 11, 2017
@whitequark whitequark modified the milestone: 3.0 Jan 11, 2017
@whitequark
Copy link
Contributor

@Evil-Spirit This crashes tests. Why do you not run tests?

@whitequark
Copy link
Contributor

Fixed in master.

@Evil-Spirit
Copy link
Collaborator Author

@whitequark, I have different build directory, so I have to run tests separately and sometimes forget to do it. Sorry, I just need to reconfigure my building env to build inside repo dir.

@whitequark
Copy link
Contributor

@Evil-Spirit OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants