-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up crowdfunding stream #265
Comments
This is not necessary. The limiting resource is not money (SolveSpace has one full-time programmer funded by M-Labs, though right now they are on hiatus) but time, specifically, time I spend on code review, merges and testing. I've had a lot of personal stuff going on recently and was unavailable to do much, which is why the project has stalled since April; that should change soon. Also, quite frankly, most payout mechanisms suck if you're not a resident of US or EU. For the amount of donations a typical open-source project receives, it is a waste of time. |
Well, I'd encourage you to diversify your funding streams and find a way to compensate third-party contributors. It's a generally useful thing to do. |
Other things to think about:
|
The website already exists in a form that's fairly easy to update but the deployment isn't configured, which is a tad annoying. Linking to 3rd party tutorials is an excellent idea, thanks. I have not so far been satisfied with the code quality of external contributions. It is regretful but true that accepting pull requests ultimately often requires more of my time than implementing a feature or fixing a bug myself (or at least that was true in every instance so far, except perhaps localizations), and with my time being the limited resource here... you see the problem. I would like to put more effort into mentoring once I clear the backlog of code to be merged, which is the current priority. |
So would you prefer creating issues for the Github/Solvespace/Website project or maybe you could |
@BPLRFE Sure, issues are good. A bit later I'll properly document the workflow and we could do PRs. |
This is not a reason for rejecting PRs. I think we can make a special branch (community branch) and merge all the good PRs and let people use it, test it and fix it themselves. When features will be proven, we can just merge it in master. |
See also: The cathedral and the bizarre. Translations available here. A shortened version covering the key points is available on wikipedia here. |
I have never seen this work in any open-source project. Why would it? Most people just want to scratch their own itch and don't have enough context to predict interactions with other code. Open-source projects that merge a lot of external contributions have two traits in common:
If we had tests that exercise most of SolveSpace's code in an automated way, this would be possible, but right now it's just a good way to have incomplete and buggy features. I am working to bring SolveSpace to the point where contributing to it is easy, but we aren't there yet. |
To add to this, I consider an application with few features that work very well far more useful than an application that has everything and a kitchen sink but little complete parts. Does FreeCAD have a working assembly workbench yet? Last time I looked they had three and none of them were usable. That's where your approach ends in. SolveSpace is as usable as it is precisely because most of its parts were developed with deep attention to detail. It's hard to scale this beyond a single person; it's also necessary to, and I'm definitely going to do it. |
Yes, this is resonable argument. But how you can predict people intensions? May be this is the first commit of the person who will contribute in a quality way in future. If you are just rejecting PR, no PRs will be from this person in future. So, no chance to achieve quality contributors without approving their first PR, no chance to have quality contrubutions in future without a bad ones before. The time is NOW, and people trying to contibute NOW, but we are not so friendly for them. Accepting PRs is just saying "hello, people, we like your work". |
I absolutely agree that we need to accept PRs and help people become productive contributors. But I can only do so many things at a time, and so there will be compromises. I've already worked out the CLA question with Jonathan, so the major obstacle to merging 3rd party code is cleared. |
@BPLRFE I've written instructions for updating the SolveSpace website. Feel free to submit or work on issues. |
There should be a way for people to give the project money. I hear patreon is a good option.
The text was updated successfully, but these errors were encountered: