Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when trying to import not .dxf or .dwg files #110

Merged
merged 1 commit into from Nov 17, 2016
Merged

Fix crash when trying to import not .dxf or .dwg files #110

merged 1 commit into from Nov 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2016

See #101

@@ -544,7 +544,7 @@ void SolveSpaceUI::MenuFile(Command id) {
ImportDxf(importFile);
} else if(Extension(importFile) == "dwg") {
ImportDwg(importFile);
} else ssassert(false, "Unexpected extension of file to import");
} else Error("Unexpected extension of file to import");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better message would be the one from export.cpp:836.

@whitequark whitequark merged commit 489ae66 into solvespace:master Nov 17, 2016
@ghost ghost deleted the fix-101-crash branch November 17, 2016 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants