Add a link to the GitHub commit at the bottom of the config screen #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1e47e6. Since unfortunately it breaks the addition of the git commit hash to the version string when building from the VisualStudio IDE. I presume this happens because `git` is not of the "path" of the build environment. The version string ends up "3.0~" only.
The "Go to GitHub commit for 3.0~129ff2f0" link at the bottom of the configuration screen opens the URL https://github.com/solvespace/solvespace/commits/129ff2f0 and allows the user to see the date of the commit that SolveSpace was built from. Closes solvespace#1172
ruevs
force-pushed
the
GitHubLinkInConfScreen
branch
from
129ff2f
to
a88f5d8
Compare
|
Oh, very nice, very pragmatic. I wonder if a new menu item in "Help" could also do the trick (there aren't too many); that'd be more discoverable. |
|
Lazy people come up with "pragmatic" solutions :-) |
|
Used the other one that puts it in the help menu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Go to GitHub commit for 3.0~a88f5d8b" link at the bottom of the configuration screen opens the URL
https://github.com/solvespace/solvespace/commits/a88f5d8band allows the user to see the date of the commit that SolveSpace was built from.Also revert f1e47e6 #1185
Closes #1172