UI: Add a link to the GitHub commit in the Help menu #1190
Conversation
This reverts commit f1e47e6. Since unfortunately it breaks the addition of the git commit hash to the version string when building from the VisualStudio IDE. I presume this happens because `git` is not of the "path" of the build environment. The version string ends up "3.0~" only.
|
I like this one better. I'm just wondering whether we should link to |
|
JFTR, Why just not add clickable link to
|
|
You'd need to support inline links in three platform implementations of the message dialog. This way, the implementation is trivial and still very effective. |
Exactly! @Symbian9 read my comment here #1172 (comment) |
|
@ruevs I just noticed you reverted the previous commit in this PR. I guess I won't merge my new PR that just does that revert since it will mess up this one ;-) |
The "Go to GitHub commit" item in the Help menu opens the URL https://github.com/solvespace/solvespace/commits/5efc148 and allows the user to see the date of the commit that SolveSpace was built from. Closes solvespace#1172
ruevs
force-pushed
the
GitHubLinkHelpMenu
branch
from
1ea4025
to
66459f2
Compare
|
Switched the link to point to |
|
@ruevs did you request 3 reviewers to get OS coverage, or just to make sure it gets looked at? ;-) |
To verify it works on all 3 OSes. It should because it doesn't require platform specific changes. BTW I prefer this one. |
An alternative to #1189
The "Go to GitHub commit" item in the Help menu opens the URL
https://github.com/solvespace/solvespace/commits/1ea4025and allows the user to see the date of the commit that SolveSpace was built from.Also revert f1e47e6 #1185
Closes #1172