Add MIME type #332
Merged
Add MIME type #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, and welcome. The SolveSpace project has a Contributor License Agreement; in order to merge your pull request, please sign it at https://cla-assistant.io/solvespace/solvespace. It will take only a small amount of your time. |
|
I've agreed to the CLA. |
whitequark
reviewed
Jul 11, 2018
| @@ -3,6 +3,7 @@ Version=1.0 | |||
| Name=SolveSpace | |||
| Comment=A parametric 2d/3d CAD | |||
| Exec=${CMAKE_INSTALL_FULL_BINDIR}/solvespace | |||
| MimeType=model/slvs | |||
There was a problem hiding this comment.
Shouldn't this be something like application/x-solvespace? I think all MIME types not explicitly assigned by IANA should be in the x- namespace.
There was a problem hiding this comment.
You're right. I'll make the change.
|
Fixed. If it's satisfactory I can squash and rebase. |
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add model/slvs MIME type, which allows .slvs files to be opened from FreeDesktop-compliant graphical environments.