Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TravisCI badge to Readme #363

Closed
wants to merge 1 commit into from
Closed

Conversation

TheKnarf
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2018

CLA assistant check
All committers have signed the CLA.

@whitequark
Copy link
Contributor

See #9. I'm not sure what the point is, personally... I don't have these on any of my FOSS projects.

@TheKnarf
Copy link
Author

TheKnarf commented Oct 18, 2018

They function as a link to the CI, without them the only way in is to click the little green mark on a specific commit. While it's not something people need that often, sometimes I find myself clicking in on the CI to check which platforms and compilers the CI is setup to build on.

The whole idea of these badges is to show some important info about the project up front for people browsing. Like what license you use and if the branch is in a working state.

It's not necessarily that fun to clone a project and try to build it locally just to find out that someone with push access has broken the master branch, since the only way of knowing that is either building it locally or checking the CI status.

But as you said @whitequark it doesn't really do much, if you don't want it in your project feel free to close the PR.

@whitequark
Copy link
Contributor

and if the branch is in a working state.

The thing is that Travis runs a horribly outdated version of Ubuntu that we can't even build the complete application on (we only build the CLI and tests currently), so the green badge is not an indicator of usability.

They function as a link to the CI, without them the only way in is to click the little green mark on a specific commit. While it's not something people need that often, sometimes I find myself clicking in on the CI to check which platforms and compilers the CI is setup to build on.

Right, but there's another issue here, which is that on branches other than master and forks these badges still point to master of the parent repo. This can get pretty confusing.

We can add explicit links to Travis and Appveyor with a note saying that these are only valid for the master branch of solvespace/solvespace, but I'm not sure if it's easier to follow the commit links instead...

@TheKnarf
Copy link
Author

We can add explicit links to Travis and Appveyor with a note saying that these are only valid for the master branch of solvespace/solvespace, but I'm not sure if it's easier to follow the commit links instead...

Seems like if the Badge doesn't add much that just following the link from commits might be just as well.

@whitequark whitequark closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants