Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate some entity copies in lathe groups. #582

Merged
merged 1 commit into from Apr 21, 2020

Conversation

phkahler
Copy link
Member

Eliminates a crash due to copy numbers going over 1000.
May break some older files with constraints on lathed entities.

@phkahler
Copy link
Member Author

Oops. This also has changes from #581

…to copy numbers going over 1000. May break some older files with constaints on lathed entities.
@phkahler
Copy link
Member Author

Rebased.

@phkahler phkahler merged commit 45eb246 into solvespace:master Apr 21, 2020
@whitequark
Copy link
Contributor

Thanks for the fix!

Can I ask you to format the git commits a bit differently? The usual convention is to put the summary on the first line, then a blank line, then a detailed description below. This makes commit messages much easier to read in tools like gitk, e.g. here's how this commit this commit looks there:

Screenshot_20200421_051602

and here's how your previous one looks (I took the liberty of reformatting it while merging):

Screenshot_20200421_051645

(They'll also be a bit easier to read on GitHub as well, though the difference is much smaller there.)

@phkahler
Copy link
Member Author

No problem. When I put a single line comment in the commit. When I created a PR it looked bad on github so I edited there. Probably best to leave it alone.

@phkahler phkahler deleted the lathe_changes branch April 21, 2020 14:08
@whitequark
Copy link
Contributor

whitequark commented Apr 21, 2020

Oh yeah, I agree it's pretty annoying that commit messages look best with manual wrapping if you're viewing them in gitk, but the very same commit messages look a lot worse on GitHub when it automatically copies them into the PR body. I expect a lot more people to read git history than pull request comments so I spend effort to make the history readable. Sometimes I edit things in the PR body to make them look nicer but that's only if a lot of people will be potentially looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants