Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly for released version 0.1.40 is marked as 0.0.0 #21

Open
RRode opened this issue Nov 23, 2017 · 9 comments
Open

Assembly for released version 0.1.40 is marked as 0.0.0 #21

RRode opened this issue Nov 23, 2017 · 9 comments

Comments

@RRode
Copy link

RRode commented Nov 23, 2017

Hi Doron,

It seems that the released version on nuget has no version set. This is then causing a compilation warning with NetMQ.

@grisharav
Copy link

Indeed, and causes also strange redirection bindings...

@sharpe5
Copy link
Contributor

sharpe5 commented Dec 13, 2017

I ran into the same issue too.

When upgrading from 1.25.0 to 1.40.0, it automatically added an assembly binding redirect into app.config:

<bindingRedirect oldVersion="0.0.0.0-0.0.0.0" newVersion="0.0.0.0" />

When I ran the project, it threw an exception:

An unhandled exception of type 'System.IO.FileLoadException' occurred in NetMQ.dll

Additional information: Could not load file or assembly 'AsyncIO, Version=0.1.25.0, Culture=neutral, PublicKeyToken=44a94435bd6f33f8' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

To fix ,I had to manually adjust the binding redirect, so all versions are redirected to version 0.0.0.0:

<configuration>
  <runtime>
    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="AsyncIO" publicKeyToken="44a94435bd6f33f8" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-0.1.40.0" newVersion="0.0.0.0" />
      </dependentAssembly>
    </assemblyBinding>
  </runtime>
</configuration>

@sharpe5
Copy link
Contributor

sharpe5 commented Dec 13, 2017

Currently, I cannot upgrade NetMQ.ReactiveExtensions to use AsyncIO v1.40. The problem is that the default assembly language binding redirect that Visual Studio adds to app.config is:

<bindingRedirect oldVersion="0.0.0.0-0.0.0.0" newVersion="0.0.0.0" />

... which has to be hand-edited to this, or else it will throw an exception on startup:

<bindingRedirect oldVersion="0.0.0.0-0.1.40.0" newVersion="0.0.0.0" />

@somdoron
Copy link
Owner

@sharpe5 can you send a pull request?

@sharpe5
Copy link
Contributor

sharpe5 commented Dec 15, 2017 via email

@sharpe5
Copy link
Contributor

sharpe5 commented Dec 17, 2017

Created a pull request, please let me know if anything needs changing.

This was a really good exercise for me. I will copy the structure of your project when I upgrade NetMQ.ReactiveExtensions to the newer .csproj file format.

Thank you again for your excellent work!

@tylerje
Copy link

tylerje commented Mar 24, 2018

Any update on this work. I'm running into the same problem.

somdoron added a commit that referenced this issue Mar 24, 2018
Pull request for issue #21: Assembly for released version 0.1.40 is marked as 0.0.0
@robvon
Copy link

robvon commented May 31, 2018

Same problem today, May 2018. Although github appears to be at version 0.1.42, nuget delivers 0.1.40 and it's internal version number is still 0.0.0.0.
In the end, I downloaded the source. Noticed a few "obsolete" warnings upon compilation

@sharpe5
Copy link
Contributor

sharpe5 commented Jun 1, 2018

Deploying the latest version 0.1.42.0 to NuGet would fix the issue, as this issue was fixed in pull request #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants