Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for issue #21: Assembly for released version 0.1.40 is marked as 0.0.0 #22

Merged
merged 16 commits into from
Mar 24, 2018

Conversation

sharpe5
Copy link
Contributor

@sharpe5 sharpe5 commented Dec 17, 2017

This pull request is for Issue #21.

Change 1: Update file AssemblyInfo.cs to include version number

Now, if I compile the NuGet package and add it to another project, the version is 1.42.0:

image

Change 2: Updated readme.md.

Added instructions for compiling and testing.

These changes are entirely optional, and can safely be omitted.

Change 3: Updated assemblies.

Updated NUnit to 3.9.0, and updated the Visual Studio 2017 test library from v15.3 to v15.5. Verified that all unit tests passed, and that the NUnit version was compatible with the ReSharper test runner.

These changes are entirely optional, and can safely be omitted.

Testing

As described in the base of the file readme.md, compiled the NuGet package locally, and tested it by adding it to a new .NET 4.0 project. Double checked that there was no assembly binding redirects, and that the version was 0.1.42.0.

Uploading new NuGet package

I ticked the box Compile NuGet package:

image

This package appears in the \bin\Release directory. I am assuming that this package would have to be uploaded manually? Not sure what the current release process is.

When I uploaded the package to NuGet, I used the command nuget push [.nupkg] [ID].

@sharpe5 sharpe5 changed the title Issue #21: Assembly for released version 0.1.40 is marked as 0.0.0 Pull request for issue #21: Assembly for released version 0.1.40 is marked as 0.0.0 Dec 17, 2017
@sharpe5
Copy link
Contributor Author

sharpe5 commented Dec 17, 2017

Will revert package upgrades to hopefully fix the CI build fail.

@sharpe5
Copy link
Contributor Author

sharpe5 commented Dec 17, 2017

Having trouble getting the CI build to pass:

image

On the CI server, it's failing with this error:

1.02s$ dotnet test Source/AsyncIO.Tests -f netcoreapp1.0
Couldn't find a project to run test from. Ensure a project exists in /home/travis/build/somdoron/AsyncIO.
Or pass the path to the project

Under Windows, if we target "netcoreapp1.0", it fails

H:\PRIMARY-CRITICAL\github\sharpe5\AsyncIO>dotnet test Source/AsyncIO.Tests -f netcoreapp1.0
Build started, please wait...
C:\Program Files\dotnet\sdk\2.1.2\Sdks\Microsoft.NET.Sdk\build\Microsoft.PackageDependencyResolution.targets(167,5): error : Assets file 'H:\PRIMARY-CRITICAL\github\sharpe5\AsyncIO\Source\AsyncIO.Tests\obj\project.assets.json' doesn't have a target for '.NETCoreApp,Version=v1.0'. Ensure that restore has run and that you have included 'netcoreapp1.0' in the TargetFrameworks for your project. [H:\PRIMARY-CRITICAL\github\sharpe5\AsyncIO\Source\AsyncIO.Tests\AsyncIO.Tests.csproj]

However, under Windows, if we target "netcoreapp2.0", it passes

H:\PRIMARY-CRITICAL\github\sharpe5\AsyncIO>dotnet test Source/AsyncIO.Tests -f netcoreapp2.0

@sharpe5
Copy link
Contributor Author

sharpe5 commented Dec 17, 2017

Spent a few hours trying to get the CI build working - can anyone else see how to fix this?

I think the problem is that the CI Travis test is configured for netcoreapp1.0, but the .csproj file is netcoreapp2.0.

I've reverted all test-related files back to how they were in the meantime.

Thanks in advance!

@somdoron somdoron merged commit 8a72d98 into somdoron:master Mar 24, 2018
@sharpe5
Copy link
Contributor Author

sharpe5 commented Mar 24, 2018

Excellent, thanks for merging this!

By the way, I am using NetMQ/AsyncIO for an Excel plugin which consumes data from another process, it is working absolutely brilliantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants