-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for issue #21: Assembly for released version 0.1.40 is marked as 0.0.0 #22
Conversation
…t in assembly binding redirect errors).
Will revert package upgrades to hopefully fix the CI build fail. |
Having trouble getting the CI build to pass: On the CI server, it's failing with this error:
Under Windows, if we target "netcoreapp1.0", it fails
However, under Windows, if we target "netcoreapp2.0", it passes
|
Spent a few hours trying to get the CI build working - can anyone else see how to fix this? I think the problem is that the CI Travis test is configured for I've reverted all test-related files back to how they were in the meantime. Thanks in advance! |
Excellent, thanks for merging this! By the way, I am using NetMQ/AsyncIO for an Excel plugin which consumes data from another process, it is working absolutely brilliantly. |
This pull request is for Issue #21.
Change 1: Update file
AssemblyInfo.cs
to include version numberNow, if I compile the NuGet package and add it to another project, the version is 1.42.0:
Change 2: Updated readme.md.
Added instructions for compiling and testing.
These changes are entirely optional, and can safely be omitted.
Change 3: Updated assemblies.
Updated NUnit to 3.9.0, and updated the Visual Studio 2017 test library from v15.3 to v15.5. Verified that all unit tests passed, and that the NUnit version was compatible with the ReSharper test runner.
These changes are entirely optional, and can safely be omitted.
Testing
As described in the base of the file
readme.md
, compiled the NuGet package locally, and tested it by adding it to a new .NET 4.0 project. Double checked that there was no assembly binding redirects, and that the version was0.1.42.0
.Uploading new NuGet package
I ticked the box
Compile NuGet package
:This package appears in the
\bin\Release
directory. I am assuming that this package would have to be uploaded manually? Not sure what the current release process is.When I uploaded the package to NuGet, I used the command
nuget push [.nupkg] [ID]
.