Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mode appears to add newlines to files it shouldn't be writing #219

Closed
somewhatabstract opened this issue Apr 16, 2020 · 1 comment · Fixed by #262
Closed

Update mode appears to add newlines to files it shouldn't be writing #219

somewhatabstract opened this issue Apr 16, 2020 · 1 comment · Fixed by #262
Assignees
@somewhatabstract
Labels
bug Something isn't working

Comments

@somewhatabstract
Copy link
Owner

Describe the bug
Saw this in the KA webapp repo. It was chaging the endings of json, csv, and sometimes even png files. But it should only be writing the files that have a mismatch. Need to debug.

To Reproduce
checksync --ignore-files lint_blacklist.txt,.gitignore -i dev/linters -m .ka_root -u on webapp

Expected behavior
Nothing should change in files that don't have a MISMATCH.

Desktop (please complete the following information):

  • OS: macOS 10.15.4
  • Node Version: 10.19.0
  • checksync Version: 2.0.0
@somewhatabstract somewhatabstract added the bug Something isn't working label Apr 16, 2020
@somewhatabstract somewhatabstract self-assigned this Apr 16, 2020
@somewhatabstract somewhatabstract mentioned this issue May 26, 2020
Merged
somewhatabstract added a commit that referenced this issue May 26, 2020
@somewhatabstract
[#219] Make sure we don't bother writing files that don't need updati…
69406cb 
…ng (#262)

* Fix typo

* Stop processing if there are no broken edges
@somewhatabstract
Copy link
Owner Author

Fixed by #262

@somewhatabstract somewhatabstract linked a pull request May 26, 2020 that will close this issue
[#219] Make sure we don't bother writing files that don't need updating #262
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somewhatabstract somewhatabstract

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#219] Make sure we don't bother writing files that don't need updating somewhatabstract/checksync
1 participant
@somewhatabstract