Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#219] Make sure we don't bother writing files that don't need updating #262

Merged
merged 2 commits into from
May 26, 2020

Conversation

somewhatabstract
Copy link
Owner

Summary
Turns out, when there are no broken edges, we were still opening and writing files when -u is specified. That's bad. So, we fixed it.

Issues
#219

Details
Also fixed a couple of typos in docs and code.

@somewhatabstract somewhatabstract self-assigned this May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          403       404    +1     
  Branches        68        68           
=========================================
+ Hits           403       404    +1     
Impacted Files Coverage Δ
src/get-markers-from-files.js 100.00% <ø> (ø)
src/validate-and-fix.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce99575...4c64f71. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mode appears to add newlines to files it shouldn't be writing
1 participant